tjbanghart commented on code in PR #3513:
URL: https://github.com/apache/calcite/pull/3513#discussion_r1391975445
##########
core/src/test/java/org/apache/calcite/plan/RelWriterTest.java:
##########
@@ -1052,6 +1053,41 @@ void testAggregateWithAlias(SqlExplainFormat format) {
assertThat(result, isLinux(expected));
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-5607";>[CALCITE-5607]</a>
+ *
+ * <p>Before the fix, RelJson.toRex would throw an ArrayIndexOutOfBounds
error
+ * when deserialization.
+ * */
+ @Test void testDeserializeMinusDateOperator() {
Review Comment:
The commit message and test case don't seem to align. This checks that
`MINUS` can be deserialized but I don't see anything to suggest we've changed
how the return `type` is being serialized.
##########
core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java:
##########
@@ -622,6 +622,7 @@ public Object toJson(RexNode node) {
}
map.put("operands", list);
switch (node.getKind()) {
+ case MINUS:
Review Comment:
We should change the Jira issue to reflect that we are only changing the
behavior of `MINUS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
