chucheng92 commented on code in PR #3524: URL: https://github.com/apache/calcite/pull/3524#discussion_r1393596223
########## site/_docs/reference.md: ########## @@ -2654,6 +2654,7 @@ BigQuery's type system uses confusingly different names for types and functions: | p | expr :: type | Casts *expr* to *type* | m | expr1 <=> expr2 | Whether two values are equal, treating null values as the same, and it's similar to `IS NOT DISTINCT FROM` | * | ACOSH(numeric) | Returns the inverse hyperbolic cosine of *numeric* +| s | ARRAY() | Construct an empty array in Apache Spark Review Comment: thanks for reviewing. IMHO, The empty array is special, and it will be highlighted here to make it clearer to users (we also have many override functions in reference doc). Of course, we can merge it in the next line, but I may not want to modify the parameter form of `ARRAY(expr [, expr ]*)` and only add a description of an empty array. what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
