tanclary commented on code in PR #3528: URL: https://github.com/apache/calcite/pull/3528#discussion_r1397689294
########## site/_docs/reference.md: ########## @@ -2823,7 +2823,7 @@ BigQuery's type system uses confusingly different names for types and functions: | b m o p | SOUNDEX(string) | Returns the phonetic representation of *string*; throws if *string* is encoded with multi-byte encoding such as UTF-8 | s | SOUNDEX(string) | Returns the phonetic representation of *string*; return original *string* if *string* is encoded with multi-byte encoding such as UTF-8 | m | SPACE(integer) | Returns a string of *integer* spaces; returns an empty string if *integer* is less than 1 -| b | SPLIT(string [, delimiter ]) | Returns the string array of *string* split at *delimiter* (if omitted, default is comma) +| b | SPLIT(string [, delimiter ]) | Returns the string array of *string* split at *delimiter* (if omitted, default is comma). If the string is empty it returns an empty vector, otherwise, if the delimiter is empty, it returns a vector containing the original string. Review Comment: Sorry for the nit but should we remove `it returns a vector containing the original string` in favor of `if the delimiter is empty, returns *string*`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
