julianhyde commented on PR #3548: URL: https://github.com/apache/calcite/pull/3548#issuecomment-1826891089
Doesn't seem like an improvement to me. The preceding code has built `result` but you no longer check it. Since you call two different `filter` functions it would be possible for one of them to no-op and for the test to still pass. Also, new test code should use `assertThat` rather than `assertEquals` or `assertNull`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
