Anthrino commented on code in PR #3565:
URL: https://github.com/apache/calcite/pull/3565#discussion_r1416363480
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibrary.java:
##########
@@ -73,7 +73,9 @@ public enum SqlLibrary {
POSTGRESQL("p", "postgresql"),
/** A collection of operators that are in Apache Spark but not in standard
* SQL. */
- SPARK("s", "spark");
+ SPARK("s", "spark"),
+ /** A collection of operators that are in Snowflake but not in standard SQL.
*/
+ SNOWFLAKE("s", "snowflake");
Review Comment:
I could be wrong, but do these single chars point to the symbol we use in
`reference.md` to indicate the supported libraries?
If so should they be distinct symbols for each or its okay to use the same,
I see `s` is used for Spark, Snowflake and Spatial but 'MSSQL' = `q` and
'MYSQL' = `m`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
