mihaibudiu commented on code in PR #3584:
URL: https://github.com/apache/calcite/pull/3584#discussion_r1427429181
##########
testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java:
##########
@@ -7140,7 +7140,7 @@ private static Consumer<List<? extends Throwable>>
checkWarnings(
@Test void testParensInFrom() {
// UNNEST may not occur within parentheses.
// FIXME should fail at "unnest"
- sql("select *from (^unnest(x)^)")
+ sql("select * from (^unnest(x)^)")
Review Comment:
If the error message returned by the `sql()` function is wrong, then this
whole test should fail. But the test passes, so the `fails()` function
succeeds, and thus the error message seems correct: the message is `Expected
query or join`.
I don't know what you mean by "no information about unset is returned".
Returned by whom? BTW: it is not "unset", but "unnest".
I think that the comment with the FIXME should be deleted. If you are
cleaning up the code here you may as well delete the incorrect comment. The
comment was inserted 10 years ago in this revision of the file:
https://github.com/apache/calcite/commit/45b58ab07223cbb94c7cbbb9a1434a2b01a9497f#diff-53800ccbf3ab769886658b596c055f0e088cc393e1630b774269966154d088ffR5102
The error message has been fixed in the meantime, but the comment has not
been deleted at that time.
Moreover, there are many more instances where `*` is not separated by a
space in this file. Why only fix this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
