chucheng92 commented on code in PR #3571: URL: https://github.com/apache/calcite/pull/3571#discussion_r1427594175
########## site/_docs/reference.md: ########## @@ -2806,14 +2806,14 @@ BigQuery's type system uses confusingly different names for types and functions: | h s | string1 NOT RLIKE string2 | Whether *string1* does not match regex pattern *string2* (similar to `NOT LIKE`, but uses Java regex) | b o | RPAD(string, length[, pattern ]) | Returns a string or bytes value that consists of *string* appended to *length* with *pattern* | b o | RTRIM(string) | Returns *string* with all blanks removed from the end -| b | SAFE_ADD(numeric1, numeric2) | Returns *numeric1* + *numeric2*, or NULL on overflow +| b | SAFE_ADD(numeric1, numeric2) | Returns *numeric1* + *numeric2*, or NULL on overflow. Only supports BIGINT, DOUBLE, or DECIMAL arguments Review Comment: I think there will be ambiguity. The newly added comment will make users think that this function can only use BIGINT, DOUBLE, or DECIMAL. The internal transformation of integer is only internal processing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
