mihaibudiu commented on code in PR #3569:
URL: https://github.com/apache/calcite/pull/3569#discussion_r1436582231
##########
core/src/main/java/org/apache/calcite/sql/type/SqlTypeName.java:
##########
@@ -65,12 +65,16 @@ public enum SqlTypeName {
DATE(PrecScale.NO_NO, false, Types.DATE, SqlTypeFamily.DATE),
TIME(PrecScale.NO_NO | PrecScale.YES_NO, false, Types.TIME,
SqlTypeFamily.TIME),
- TIME_WITH_LOCAL_TIME_ZONE(PrecScale.NO_NO | PrecScale.YES_NO, false,
Types.OTHER,
+ TIME_WITH_LOCAL_TIME_ZONE(PrecScale.NO_NO | PrecScale.YES_NO, false,
Types.TIME,
+ SqlTypeFamily.TIME),
+ TIME_TZ(PrecScale.NO_NO | PrecScale.YES_NO, false, Types.TIME,
Review Comment:
That would be nice, but this may break any third party software that uses
Calcite.
Since we can't remove deprecated functions I assume we can't rename public
enum fields either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
