julianhyde commented on PR #3590: URL: https://github.com/apache/calcite/pull/3590#issuecomment-1871348454
Is this PR just a proof of concept? If so, let’s not merge the PoC, let’s merge a commit that does the actual task - reduces duplication of testing for aliased functions. By all means give Sergey co-author credit in that commit if appropriate. JulianOn Dec 27, 2023, at 14:07, Tanner Clary ***@***.***> wrote: It's still marked as draft for some reason. I converted to ready for review, hope that's alright. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
