zstan commented on code in PR #3522:
URL: https://github.com/apache/calcite/pull/3522#discussion_r1438063133
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -13412,6 +13414,34 @@ private static void
checkLogicalOrFunc(SqlOperatorFixture f) {
}
}
+ /**
+ * Test cases for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6111";>[CALCITE-6111]
+ * Explicit cast from expression to numeric type doesn't check overflow</a>.
*/
+ @Test public void testOverflow() {
+ final SqlOperatorFixture f = fixture();
+ f.checkFails("SELECT cast(100+30 as tinyint)",
Review Comment:
as for me - it`s hard to parse such a tests.
```suggestion
f.checkFails(String.format("SELECT cast(%d+30 as tinyint)",
Byte.MAX_VALUE),
```
and the same for all near
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
