This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git
commit 3c19347cc45349a21a8c97d6f6e8d3e9f596070f Author: Julian Hyde <[email protected]> AuthorDate: Thu Jan 4 12:13:04 2024 -0800 [CALCITE-6187] Linter should disallow tags such as '[MINOR]' in commit messages --- core/src/test/java/org/apache/calcite/test/LintTest.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/core/src/test/java/org/apache/calcite/test/LintTest.java b/core/src/test/java/org/apache/calcite/test/LintTest.java index a0ceb69e3e..1e36cfd020 100644 --- a/core/src/test/java/org/apache/calcite/test/LintTest.java +++ b/core/src/test/java/org/apache/calcite/test/LintTest.java @@ -346,6 +346,8 @@ class LintTest { hasSize(1)); assertThat(f.apply("[CALCITE-4817] cannot start with lower-case", ""), hasItem("Message must start with upper-case letter")); + assertThat(f.apply("[MINOR] Lint", ""), + hasItem("starts with '[', and is not '[CALCITE-nnnn]'")); // If 'Lint:skip' occurs in the body, no checks are performed assertThat( @@ -375,6 +377,9 @@ class LintTest { + "problem, not what you did"); } } + if (subject2.startsWith("[")) { + consumer.accept("starts with '[', and is not '[CALCITE-nnnn]'"); + } if (subject2.startsWith(" ")) { consumer.accept("starts with space"); }
