caicancai commented on code in PR #3608:
URL: https://github.com/apache/calcite/pull/3608#discussion_r1442439053
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -12230,6 +12235,8 @@ void testTimestampDiff(boolean coercionEnabled) {
f.checkScalar("time_trunc(time '12:34:56', hour)",
"12:00:00", "TIME(0) NOT NULL");
f.checkNull("time_trunc(cast(null as time), second)");
+ f.checkNull("time_trunc(cast(null as time), minute)");
Review Comment:
I just tested and it seems that the second parameter is null is not allowed,
which will fail to parse
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -12230,6 +12235,8 @@ void testTimestampDiff(boolean coercionEnabled) {
f.checkScalar("time_trunc(time '12:34:56', hour)",
"12:00:00", "TIME(0) NOT NULL");
f.checkNull("time_trunc(cast(null as time), second)");
+ f.checkNull("time_trunc(cast(null as time), minute)");
Review Comment:
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
