HanumathRao commented on code in PR #3597:
URL: https://github.com/apache/calcite/pull/3597#discussion_r1445130564


##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -4177,6 +4178,109 @@ RelOptFixture checkDynamicFunctions(boolean 
treatDynamicCallsAsConstant) {
         .check();
   }
 
+  @Test void testJoinWithConstantRowOnRight() {

Review Comment:
   @mihaibudiu  Thanks for the review, the above query doesn't result in an 
empty subset as it is a cross join. I have added the test case and made sure 
that the results are same with and without the optimization (by removing the 
rules  and executing the test case). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to