julianhyde commented on code in PR #3611:
URL: https://github.com/apache/calcite/pull/3611#discussion_r1445420180
##########
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##########
@@ -41,6 +41,13 @@
* @see FormatModels#DEFAULT
*/
public enum FormatElementEnum implements FormatElement {
+ CC("cc", "century (2 digits) (the twenty-first century starts on
2001-01-01)") {
Review Comment:
+1
I won't even review a PR until the jira case has a good description of its
goals. Sounds pedantic but it's very pragmatic.
This jira case also needs to say which functions these date formats are
supported in. Changes to FormatElementEnum are not useful unless they are
surfaced in functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
