asolimando commented on PR #3522: URL: https://github.com/apache/calcite/pull/3522#issuecomment-1895541892
> > After @snuyanzin's comment I feel we need to get to the bottom of the test issue before merging, therefore marking the PR as "request changes" until clarified > > I have made the fixes you suggested. The tests should be run from the class CalciteSqlOperatorTest to exercise the evaluator. Thanks Mihai, the changes and the patch LGTM, can you please address the Sonar violation regarding the repeated occurrence of the string `".* out of range"`? (just define it once at the beginning of the test for better maintainability in case the error messages changes). PS: please don't force-push while the review process is still on-going, it makes reviewers' life more difficult for not much gain, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
