tanclary commented on code in PR #3631:
URL: https://github.com/apache/calcite/pull/3631#discussion_r1457869015
##########
core/src/main/java/org/apache/calcite/sql/SqlKind.java:
##########
@@ -457,6 +457,9 @@ public enum SqlKind {
/** {@code TIME_SUB} function (BigQuery). */
TIME_SUB,
+ /** {@code TIMESTAMP} function (BigQuery). */
+ TIMESTAMP,
Review Comment:
Done, didn't need to add that anyways I don't think.
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -1610,6 +1610,36 @@ private static RelDataType
deriveTypeMapFromEntries(SqlOperatorBinding opBinding
OperandTypes.STRING_STRING,
SqlFunctionCategory.TIMEDATE);
+ /** The "TO_TIMESTAMP_LTZ" function returns a Calcite
+ * {@code TIMESTAMP WITH LOCAL TIME ZONE}.
+ * It has the following overloads (Snowflake also
+ * supports a variant and quoted integer overload but
+ * those are not yet supported):
+ *
+ * <ul>
+ * <li>{@code TO_TIMESTAMP_LTZ(numeric[, scale)]}
+ * <li>{@code TO_TIMESTAMP_LTZ(date)}
+ * <li>{@code TO_TIMESTAMP_LTZ(datetime)}
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
