tanclary commented on code in PR #3639:
URL: https://github.com/apache/calcite/pull/3639#discussion_r1459320707
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7704,6 +7703,101 @@ private void checkLiteral2(String expression, String
expected) {
sql(query).withSpark().withLibrary(SqlLibrary.SPARK).ok(expectedSql);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6213";>[CALCITE-6213]
+ * The default behavior of NullCollation in Presto is LAST </a>.
+ */
+ @Test void testNullCollation() {
+ final String query = "select * from \"product\" order by \"brand_name\"";
+ final String expected = "SELECT *\n"
+ + "FROM \"foodmart\".\"product\"\n"
+ + "ORDER BY \"brand_name\"";
+ final String sparkExpected = "SELECT *\n"
Review Comment:
I'm confused why we are also testing for Spark?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
