mihaibudiu commented on code in PR #3634:
URL: https://github.com/apache/calcite/pull/3634#discussion_r1460126458
##########
core/src/test/java/org/apache/calcite/examples/foodmart/java/JdbcExample.java:
##########
@@ -43,8 +43,8 @@ public void run() throws ClassNotFoundException, SQLException
{
CalciteConnection calciteConnection =
connection.unwrap(CalciteConnection.class);
SchemaPlus rootSchema = calciteConnection.getRootSchema();
- rootSchema.add("hr", new ReflectiveSchema(new Hr()));
- rootSchema.add("foodmart", new ReflectiveSchema(new Foodmart()));
+ rootSchema.add("hr", new ReflectiveSchemaWithoutRowCount(new Hr()));
Review Comment:
what happens here if you don't make the change?
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -5002,7 +5001,7 @@ public boolean moveNext() {
CalciteAssert.that()
.withSchema("s",
- new ReflectiveSchema(
+ new ReflectiveSchemaWithoutRowCount(
Review Comment:
this test even seems to be disabled, why do you need to change it?
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -709,7 +708,7 @@ private void checkTableFunctionInModel(Class<?> clazz) {
CalciteConnection connection = (CalciteConnection)
driver.connect("jdbc:calcite:", new Properties());
SchemaPlus rootSchema = connection.getRootSchema();
- rootSchema.add("hr", new ReflectiveSchema(new HrSchema()));
+ rootSchema.add("hr", new ReflectiveSchemaWithoutRowCount(new
HrSchema()));
Review Comment:
same question: what happens if you don't change the schema
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -709,7 +708,7 @@ private void checkTableFunctionInModel(Class<?> clazz) {
CalciteConnection connection = (CalciteConnection)
driver.connect("jdbc:calcite:", new Properties());
SchemaPlus rootSchema = connection.getRootSchema();
- rootSchema.add("hr", new ReflectiveSchema(new HrSchema()));
+ rootSchema.add("hr", new ReflectiveSchemaWithoutRowCount(new
HrSchema()));
Review Comment:
for many of these tests I would expect they would continue to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
