chucheng92 commented on code in PR #3642: URL: https://github.com/apache/calcite/pull/3642#discussion_r1462668798
########## site/_docs/reference.md: ########## @@ -2859,7 +2859,7 @@ In the following: | b | TIME_DIFF(time, time2, timeUnit) | Returns the whole number of *timeUnit* between *time* and *time2* | b | TIME_SUB(time, interval) | Returns the TIME value that is *interval* before *time* | b | TIME_TRUNC(time, timeUnit) | Truncates *time* to the granularity of *timeUnit*, rounding to the beginning of the unit -| m o p | TO_CHAR(timestamp, format) | Converts *timestamp* to a string using the format *format* +| m o p | TO_CHAR(timestamp, format) | Converts *timestamp* to a string using the format *format* [More details](https://www.postgresql.org/docs/16/functions-formatting.html#FUNCTIONS-FORMATTING-DATETIME-TABLE) Review Comment: your commit/pr want to add a PG format for century. but here m/o/p means MySQL/Oracle/PG, why only have pg link (and why pg-16.0)? If so, shall we add other links for other functions? we need to think about it. Generally speaking, calcite does not explicitly add external links to each engine. This will destroy the format of the current reference.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
