julianhyde commented on code in PR #3644:
URL: https://github.com/apache/calcite/pull/3644#discussion_r1465615674
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -5538,7 +5538,7 @@ ImmutableList<RelNode> retrieveCursors() {
case ARRAY_QUERY_CONSTRUCTOR:
call = (SqlCall) expr;
query = Iterables.getOnlyElement(call.getOperandList());
- root = convertQueryRecursive(query, false, null);
+ root = convertQueryRecursive(query, true, null);
Review Comment:
Agree. Perhaps rename `boolean top` to `boolean preserveOrderBy` (assuming
that `top` doesn't control any other behavior). Then the documentation can be
on the `convertQueryRecursive` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
