mihaibudiu commented on code in PR #3635:
URL: https://github.com/apache/calcite/pull/3635#discussion_r1468522157
##########
core/src/main/java/org/apache/calcite/rex/RexUtil.java:
##########
@@ -1683,7 +1683,7 @@ public static boolean isLosslessCast(RexNode node) {
*
* @param source source type
* @param target target type
- * @return true iff the conversion is a loss-less cast
+ * @return true if the conversion is a loss-less cast
Review Comment:
I know, but this function does not return "true" if and only if, it returns
it only "if", because it is an aproximation.
So I think the original comment was wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
