kramerul commented on code in PR #3658: URL: https://github.com/apache/calcite/pull/3658#discussion_r1470712364
########## core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java: ########## @@ -257,6 +257,48 @@ public Result visit(Join e) { return result(join, leftResult, rightResult); } + private Result maybeFixRenamedFields(Result rightResult, Join e) { Review Comment: The class `RelToSqlConverter` is only used in `JdbcImplementor` and `PigRelToSqlConverter`. Both classes are related to JDBC. Therefore, I would like to keep the title of the issue. Additionally Julian Hyde added the JDBC relation to the title -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org