zabetak commented on code in PR #3661:
URL: https://github.com/apache/calcite/pull/3661#discussion_r1474526470


##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableBatchNestedLoopJoin.java:
##########
@@ -55,6 +55,7 @@
 public class EnumerableBatchNestedLoopJoin extends Join implements 
EnumerableRel {
 
   private final ImmutableBitSet requiredColumns;
+  private final Join originalJoin;

Review Comment:
   Keeping a RelNode in another RelNode is a strange pattern that we shall 
better avoid. Other than that adding attributes may necessitate touching the 
digest which may further complicate the situation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to