YiwenWu commented on code in PR #3668: URL: https://github.com/apache/calcite/pull/3668#discussion_r1476931157
########## core/src/main/java/org/apache/calcite/sql/dialect/PostgisSqlDialect.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql.dialect; + +import org.apache.calcite.avatica.util.Casing; +import org.apache.calcite.sql.SqlCall; +import org.apache.calcite.sql.SqlDialect; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.util.RelToSqlConverterUtil; + +/** + * A <code>SqlDialect</code> implementation for the PostgreSQL database. + */ +public class PostgisSqlDialect extends PostgresqlSqlDialect { + + public static final SqlDialect.Context DEFAULT_CONTEXT = SqlDialect.EMPTY_CONTEXT + .withDatabaseProduct(DatabaseProduct.POSTGIS) + .withIdentifierQuoteString("\"") + .withUnquotedCasing(Casing.TO_LOWER) + .withDataTypeSystem(POSTGRESQL_TYPE_SYSTEM); + + public static final SqlDialect DEFAULT = new PostgisSqlDialect(DEFAULT_CONTEXT); + + /** Creates a PostgresqlSqlDialect. */ + public PostgisSqlDialect(Context context) { + super(context); + } + + @Override public void unparseCall(SqlWriter writer, SqlCall call, int leftPrec, int rightPrec) { Review Comment: Since PostGIS is an extension of PostgreSQL, Can these changes be processed directly in PostgresqlSqlDialect? ########## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ########## @@ -7876,6 +7878,26 @@ private void checkLiteral2(String expression, String expected) { .withSpark().ok(sparkExpected); } + /** + * Test case for ST_SRID function. + * All the spatial functions where the arguments are the same type should behave similarly. + */ + @Test void testPostgisStSrid() { + String query = "select st_srid(\"point\") FROM \"points\""; + String expectedPostgis = "SELECT \"ST_SRID\"(\"point\")\nFROM \"GEO\".\"points\""; Review Comment: Some UT tests failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
