rubenada commented on code in PR #3650:
URL: https://github.com/apache/calcite/pull/3650#discussion_r1481299196
##########
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##########
@@ -620,6 +620,13 @@ public static SqlCall stripSeparator(SqlCall call) {
public static final SqlReturnTypeInference MULTISET_ELEMENT_NULLABLE =
Review Comment:
My two cents: in this particular case, I'd vote for removing the (now
unused) `MULTISET_ELEMENT_NULLABLE`.
It is true that it might be used by a 3rd party library, but since the name
was misleading, I think that those potential 3rd party libraries could be
suffering from the same issue as CALCITE-6228, so by having a compilation
problem after the next Calcite upgrade, they'd be force to analyze their usage
of `MULTISET_ELEMENT_NULLABLE` and maybe switch to the new
`MULTISET_ELEMENT_FORCE_NULLABLE` (or define their own `SqlReturnTypeInference`
if they choose so).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
