mihaibudiu commented on code in PR #3672:
URL: https://github.com/apache/calcite/pull/3672#discussion_r1482322829
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java:
##########
@@ -1802,11 +1802,11 @@ public class SqlStdOperatorTable extends
ReflectiveSqlOperatorTable {
OperandTypes.NUMERIC,
SqlFunctionCategory.NUMERIC);
- /** The {@code TRUNCATE(numeric [, numeric])} function. */
+ /** The {@code TRUNCATE(numeric [, integer])} function. */
public static final SqlBasicFunction TRUNCATE =
SqlBasicFunction.create("TRUNCATE",
ReturnTypes.ARG0_NULLABLE,
- OperandTypes.NUMERIC_OPTIONAL_INTEGER,
+
OperandTypes.NUMERIC.or(OperandTypes.NUMERIC_INT32.apply("TRUNCATE")),
Review Comment:
I have renamed the JIRA case and the PR, I will fix the commit message when
I squash.
I have added the suggested new unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
