rubenada commented on code in PR #3675:
URL: https://github.com/apache/calcite/pull/3675#discussion_r1482547365
##########
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java:
##########
@@ -1799,11 +1801,16 @@ private boolean innerHasNext() {
i = -1;
}
- @Override public void close() {
- outerEnumerator.close();
+ private void closeInner() {
Review Comment:
Interesting point.
Maybe I'm wrong, but my understanding is that our enumerators are not
thread-safe, so if a 3rd party uses them on a multi-threaded environment, they
would need to handle synchronization on their end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
