Anthrino commented on code in PR #3678:
URL: https://github.com/apache/calcite/pull/3678#discussion_r1483769028
##########
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##########
@@ -81,6 +81,13 @@ public enum FormatElementEnum implements FormatElement {
sb.append(work.eeeFormat.format(date));
}
},
+ E("d", "The day of the month as a decimal number (01-31) left-padded with
space") {
Review Comment:
Hi @mihaibudiu, all changes looks good to me.
We can replace `(01-31)` in the comment to `(1-31)`, and maybe mention
"single digits left-padded with space" to avoid confusion and align with BQ
docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
