mihaibudiu commented on code in PR #3680:
URL: https://github.com/apache/calcite/pull/3680#discussion_r1484933365
##########
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##########
@@ -281,9 +301,9 @@ static Work get() {
/** Uses Locale.US instead of Locale.ROOT to fix formatting in Java 11 */
final DateFormat eeeeFormat = new SimpleDateFormat(DAY.javaFmt, Locale.US);
- final DateFormat eeeFormat = new SimpleDateFormat(DY.javaFmt, Locale.ROOT);
- final DateFormat mmmFormat = new SimpleDateFormat(MON.javaFmt,
Locale.ROOT);
- final DateFormat mmmmFormat = new SimpleDateFormat(MONTH.javaFmt,
Locale.ROOT);
+ final DateFormat eeeFormat = new SimpleDateFormat(DY.javaFmt, Locale.US);
Review Comment:
SQL requires the output to be in English. Using Locale.ROOT gives the wrong
result for the eeeeFormat at least (Mon instead of Monday).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
