JiajunBernoulli commented on code in PR #3683:
URL: https://github.com/apache/calcite/pull/3683#discussion_r1485791732
##########
core/src/main/java/org/apache/calcite/sql/dialect/PrestoSqlDialect.java:
##########
@@ -131,8 +136,30 @@ private static void unparseUsingLimit(SqlWriter writer,
@Nullable SqlNode offset
RelToSqlConverterUtil.specialOperatorByName("APPROX_DISTINCT")
.unparse(writer, call, 0, 0);
} else {
- // Current impl is same with Postgresql.
- PostgresqlSqlDialect.DEFAULT.unparseCall(writer, call, leftPrec,
rightPrec);
+ switch (call.getKind()) {
Review Comment:
Extract them to `createMapValueConstuctor` function is bettter.
> I like single responsibility principle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
