mihaibudiu commented on code in PR #3686:
URL: https://github.com/apache/calcite/pull/3686#discussion_r1489867427
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -2276,6 +2276,12 @@ protected void registerNamespace(
if (namespace == null) {
namespaces.put(requireNonNull(ns.getNode()), ns);
namespace = ns;
+ } else {
Review Comment:
This code does not respect the style guidelines of Calcite.
`./gradlew build` will show you the problems.
However, more importantly, this does not look like a suitable error message
for a user of Calcite.
Is this an internal error or the compiler? Then perhaps you should use an
assertion.
Even better would be to fix the error. The issue you have filed suggests
that you are fixing the problem, but it seems that you aren't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
