YiwenWu commented on code in PR #3682:
URL: https://github.com/apache/calcite/pull/3682#discussion_r1493753164
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -4506,13 +4600,16 @@ private void checkLiteral2(String expression, String
expected) {
String expectedPresto = "SELECT DATE_TRUNC('MINUTE', \"hire_date\")\n"
+ "FROM \"foodmart\".\"employee\"";
String expectedFirebolt = expectedPostgresql;
+ String expectedStarRocks = "SELECT DATE_FORMAT(`hire_date`, '%Y-%m-%d
%H:%i:00')\n"
Review Comment:
Indeed, this test case directly uses `MysqlSqlDialect#unparseFloor`,
MySQL/StarRocks Function DATE_FORMAT returns a string. [date_format
docs](https://docs.starrocks.io/docs/2.1/sql-reference/sql-functions/date-time-functions/date_format/)
StarRocks also support function
[date_trunc](https://docs.starrocks.io/docs/2.1/sql-reference/sql-functions/date-time-functions/date_trunc/),
replace with DATE_TRUNC function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
