tanclary commented on code in PR #3688:
URL: https://github.com/apache/calcite/pull/3688#discussion_r1498379673
##########
core/src/main/java/org/apache/calcite/sql/validate/IdentifierNamespace.java:
##########
@@ -245,6 +244,24 @@ private SqlValidatorNamespace resolveImpl(SqlIdentifier
id) {
return rowType;
}
+ @Override public void validateAlwaysFilter(Set<String> alwaysFilterFields) {
+ resolvedNamespace = resolveImpl(id);
+ if (resolvedNamespace instanceof TableNamespace) {
Review Comment:
similar comment for some of these checks, we could change it to check if
something is NOT true, and if it isn't then we just return, otherwise continue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
