caicancai commented on code in PR #3689: URL: https://github.com/apache/calcite/pull/3689#discussion_r1498546565
########## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ########## @@ -2788,6 +2788,18 @@ public static double log(BigDecimal d0, BigDecimal d1) { return Math.log(d0.doubleValue()) / Math.log(d1.doubleValue()); } + /** SQL {@code LOG2(number)} function applied to double values. */ + public static double log2(double d0) { + return (Double.isInfinite(log(d0, 2)) && d0 == 0.0) ? Double.NaN : log(d0, 2); + } + + /** SQL {@code LOG2(number)} function applied to + * BigDecimal and double values. */ + public static double log2(BigDecimal d0) { + return (Double.isInfinite(log(d0, 2)) && d0.doubleValue() == 0.0) ? Double.NaN : log(d0, 2); Review Comment: @tanclary To be honest, I could have completed the changes and handed them over to you for review, but during the adaptation process, I found that I had a lot of doubts about this, which led me to ask you many questions. Perhaps this is the reason why this PR has been discussed for so long. It is very Thank you for your patient answers. At the same time, it has taken up a lot of your time. I'm sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org