tanclary commented on code in PR #3697:
URL: https://github.com/apache/calcite/pull/3697#discussion_r1502080680
##########
core/src/test/java/org/apache/calcite/sql/type/RelDataTypeSystemTest.java:
##########
@@ -36,9 +43,13 @@
class RelDataTypeSystemTest {
/**
- * Custom type system class that overrides the default decimal plus type
derivation.
+ * Custom type system class that overrides the default decimal plus type
derivation and
+ * overrides the max precision for timestamps.
*/
private static final class CustomTypeSystem extends RelDataTypeSystemImpl {
+ // Arbitrarily choose a different maximum timestamp precision from the
default.
+ private static final int CUSTOM_MAX_TIMESTAMP_PRECISION =
+ SqlTypeName.MAX_DATETIME_PRECISION + 3;
Review Comment:
I think he just chose an arbitrary number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
