vaijosh commented on code in PR #239:
URL: https://github.com/apache/calcite-avatica/pull/239#discussion_r1502413193
##########
server/src/test/java/org/apache/calcite/avatica/server/HttpServerSpnegoWithoutJaasTest.java:
##########
@@ -186,6 +187,14 @@ private static void setupUsers(File keytabDir) throws
KrbException {
assertEquals(401, conn.getResponseCode());
}
+ @Test public void testServerVersionNotReturnedForUnauthorisedAccess() throws
Exception {
Review Comment:
Yes, the test runtime is insignificant (119ms). The Jetty server mentioned
in the HTTP Response header is not associated with any authentication mechanism
or SSL configurations. I opted for unauthorized access scenarios during
validation because they are easy to reproduce. However, I am unclear about the
rationale behind invoking it from every class.
Could you please elaborate on which specific tests require the inclusion of
this new method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
