rubenada commented on code in PR #3696:
URL: https://github.com/apache/calcite/pull/3696#discussion_r1502433644
##########
elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchRules.java:
##########
@@ -113,8 +113,7 @@ static List<String> elasticsearchFieldNames(final
RelDataType rowType) {
return SqlValidatorUtil.uniquify(
new AbstractList<String>() {
@Override public String get(int index) {
- final String name = rowType.getFieldList().get(index).getName();
- return name.startsWith("$") ? "_" + name.substring(2) : name;
+ return rowType.getFieldList().get(index).getName();
Review Comment:
Before tearing down this chesterton fence... do we know what was the logic
behind this piece of code that you propose to remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
