mihaibudiu commented on code in PR #3687:
URL: https://github.com/apache/calcite/pull/3687#discussion_r1503366644
##########
core/src/test/java/org/apache/calcite/test/JdbcTest.java:
##########
@@ -8301,6 +8302,65 @@ private void checkGetTimestamp(Connection con) throws
SQLException {
});
}
+ @Test void bindByteParameter() {
+ for (SqlTypeName tpe : SqlTypeName.INT_TYPES) {
+ final String sql =
+ "with cte as (select cast(100 as " + tpe.getName() + ") as empid)"
+ + "select * from cte where empid = ?";
+ CalciteAssert.hr()
+ .query(sql)
+ .consumesPreparedStatement(p -> {
+ p.setByte(1, (byte) 100);
+ })
+ .returnsUnordered("EMPID=100");
+ }
+ }
+
+ @Test void bindShortParameter() {
+ for (SqlTypeName tpe : SqlTypeName.INT_TYPES) {
+ final String sql =
+ "with cte as (select cast(100 as " + tpe.getName() + ") as empid)"
+ + "select * from cte where empid = ?";
+
+ CalciteAssert.hr()
+ .query(sql)
+ .consumesPreparedStatement(p -> {
+ p.setShort(1, (short) 100);
+ })
+ .returnsUnordered("EMPID=100");
+ }
+ }
+
+ @Test void bindIntParameter() {
+ for (SqlTypeName tpe : SqlTypeName.INT_TYPES) {
+ final String sql =
+ "with cte as (select cast(100 as " + tpe.getName() + ") as empid)"
+ + "select * from cte where empid = ?";
+
+ CalciteAssert.hr()
+ .query(sql)
+ .consumesPreparedStatement(p -> {
+ p.setInt(1, 100);
+ })
+ .returnsUnordered("EMPID=100");
+ }
+ }
+
+ @Test void bindLongParameter() {
Review Comment:
Can you also add a test where the value overflows the type, e.g., TINYINT
with a value of 300?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
