chucheng92 commented on PR #3706: URL: https://github.com/apache/calcite/pull/3706#issuecomment-1970353706
> > make sense. I just read it wrong. Your PR only handles the situation when array arg is NULL. My point is that the element is also a NULL literal. > > There are already tests for this case, e.g.: `testArrayAppendFunc` If the first array arg is NULL, then it is an exception for all these array functions. There is no doubt about this, but if the second arg is NULL, the semantics are different. `array_contains/array_except/array_intersect` is currently wrong. And you are right to mention `array_append/array_prepend` as it does insert null.  yes, I have fixed `array_contains/array_except/array_intersect` in that PR, and that PR will affect this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
