caicancai commented on code in PR #3705:
URL: https://github.com/apache/calcite/pull/3705#discussion_r1507043922
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorUtil.java:
##########
@@ -1381,6 +1424,58 @@ private static void adjustTypeForMultisetConstructor(
}
}
+ /**
+ * Adjusts the types for operands in a SqlCallBinding during the
construction of a sql collection
+ * type such as array_append and array_prepend, but cannot change the data
type in the array.
+ *
+ * @param evenType the {@link RelDataType} to which the operands at even
positions should be cast
+ * @param oddType the {@link RelDataType} to which the operands at odd
positions should be cast
+ * @param sqlCallBinding the {@link SqlCallBinding} containing the operands
to be adjusted
+ */
+ private static void adjustTypeForMultisetConstructor2(
Review Comment:
I'm thinking about whether adjustTypeForMultisetConstructor2 and
adjustTypeForMultisetConstructor3 can be combined into one function. At
present, I don't have a good solution, so I separate the two functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
