YiwenWu commented on code in PR #3709:
URL: https://github.com/apache/calcite/pull/3709#discussion_r1509905708
##########
core/src/main/java/org/apache/calcite/plan/Strong.java:
##########
@@ -53,8 +53,6 @@
* <li>{@code p1 AND p2} is strong in [p1, p2] (definitely null if either p1
* is null or p2 is null)
* <li>{@code p1 OR p2} is strong if p1 and p2 are strong
- * <li>{@code c1 = 1 OR c2 IS NULL} is strong in [c1] (definitely null if c1
Review Comment:
LGTM.
By the way, can you also correct the spelling error of the IDEA prompt,
changing `with regards to` to `with regard to`.
https://github.com/apache/calcite/blob/c546d4a59cf1cb20e6ec2a8981decf179d9a6b50/core/src/main/java/org/apache/calcite/plan/Strong.java#L41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
