caicancai commented on code in PR #3711:
URL: https://github.com/apache/calcite/pull/3711#discussion_r1509907088
##########
core/src/main/java/org/apache/calcite/util/BuiltInMethod.java:
##########
@@ -510,7 +510,7 @@ public enum BuiltInMethod {
SAFE_MULTIPLY(SqlFunctions.class, "safeMultiply", double.class,
double.class),
SAFE_SUBTRACT(SqlFunctions.class, "safeSubtract", double.class,
double.class),
LOG(SqlFunctions.class, "log", long.class, long.class),
- LOG2(SqlFunctions.class, "log2", long.class),
+ LOGMS(SqlFunctions.class, "logMS", long.class, long.class),
Review Comment:
The log2 function was originally designed to adapt to mysql and spark
functions. This pr adapts to the behavior of all log functions in mysql and
spark. I made some reasonable reconstructions. In order to improve the
readability and maintainability of the code, you can Found that the log2
function is still effective
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
