tanclary commented on code in PR #3714:
URL: https://github.com/apache/calcite/pull/3714#discussion_r1511778798
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -2161,9 +2161,12 @@ private static RelDataType
deriveTypeMapFromEntries(SqlOperatorBinding opBinding
public static final SqlFunction POW =
SqlStdOperatorTable.POWER.withName("POW");
+ /** The "TRUNC(numeric1 [, integer2])" function. Identical to the standard
<code>TRUNCATE</code>
+ * function except the return type should be a double if numeric1 is an
integer. */
@LibraryOperator(libraries = {BIG_QUERY})
- public static final SqlFunction TRUNC =
- SqlStdOperatorTable.TRUNCATE.withName("TRUNC");
+ public static final SqlFunction TRUNC = SqlStdOperatorTable.TRUNCATE
Review Comment:
I think renaming it might be a bit redundant, I only renamed FLOOR and CEIL
because they have standard counterparts with the same name, TRUNC however is
unique from the standard TRUNCATE. What do you think? I don't feel very
strongly either way. @julianhyde
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
