caicancai commented on code in PR #3732:
URL: https://github.com/apache/calcite/pull/3732#discussion_r1525040413
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -6295,6 +6295,20 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias functionAlias) {
f.checkNull("log(10, cast(null as real))");
}
+ @Test void testLogFuncByOneParameter() {
Review Comment:
add testLogfunc
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -2788,15 +2788,26 @@ public static double log(BigDecimal d0, BigDecimal d1) {
return Math.log(d0.doubleValue()) / Math.log(d1.doubleValue());
}
- /** SQL {@code LOG2(number)} function applied to double values. */
- public static @Nullable Double log2(double number) {
- return (number <= 0) ? null : log(number, 2);
+ /** SQL {@code LOG(number, number2)} function applied to double values. */
+ public static @Nullable Double logMS(double number, double number2) {
+ return (number <= 0) ? null : log(number, number2);
+ }
+
+ /** SQL {@code LOGMS(number, number2)} function applied to
+ * double and BigDecimal values. */
+ public static @Nullable Double logMS(double number, BigDecimal number2) {
+ return (number <= 0) ? null : log(number, number2);
+ }
+
+ /** SQL {@code LOGMS(number, number2)} function applied to
+ * BigDecimal and double values. */
+ public static @Nullable Double logMS(BigDecimal number, double number2) {
+ return (number.doubleValue() <= 0) ? null : log(number, number2);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
