jduo commented on code in PR #3663:
URL: https://github.com/apache/calcite/pull/3663#discussion_r1529043905
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -4065,7 +4065,7 @@ private SqlDialect nonOrdinalDialect() {
+ " select \"product_id\", 0 as \"net_weight\"\n"
+ " from \"sales_fact_1997\") t0";
final String expected = "SELECT SUM(CASE WHEN \"product_id\" = 0"
- + " THEN \"net_weight\" ELSE 0 END) AS \"NET_WEIGHT\"\n"
+ + " THEN \"net_weight\" ELSE 0E0 END) AS \"NET_WEIGHT\"\n"
Review Comment:
I think we'd be hard-pressed to have users use this literal FYI
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -388,7 +388,7 @@ private static String toSql(RelNode root, SqlDialect
dialect,
+ "where \"net_weight\" <> 10 or \"net_weight\" is null";
final String expected = "SELECT \"product_id\", \"shelf_width\"\n"
+ "FROM \"foodmart\".\"product\"\n"
- + "WHERE \"net_weight\" <> 10 OR \"net_weight\" IS NULL";
+ + "WHERE \"net_weight\" <> CAST(10 AS DOUBLE) OR \"net_weight\" IS
NULL";
Review Comment:
Would users need to make changes to queries such as these? Is 10 no longer
implicitly converted to double when comparing to double columns?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
