caicancai commented on code in PR #3732:
URL: https://github.com/apache/calcite/pull/3732#discussion_r1529569975
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -4127,14 +4130,14 @@ private static class LogicalNotImplementor extends
AbstractRexCallImplementor {
* <p>Handles all logarithm functions using log rules to determine the
* appropriate base (i.e. base e for LN).
*/
- private static class LogImplementor extends AbstractRexCallImplementor {
- LogImplementor() {
- super("log", NullPolicy.STRICT, true);
+ private static class LogImplementor extends MethodImplementor {
+ LogImplementor(Method method) {
+ super(method, NullPolicy.STRICT, true);
Review Comment:
@tanclary I hope you can listen to my analysis here, because the functions
of log and log_mysql_spark in sqlfunctions are different. If it is passed in
through a string, I also need to judge whether the string is log or
log_mysql_spark. If it is passed through the method method, I don’t seem to
need to Do this.
Later, we also need to consider the log adaptation of postgres. Its
argValueList.size() == 1 situation is different from that of bigquery and
mysql. At that time, I only need method.getname to judge and align for
processing. I thought so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
