normanj-bitquill commented on code in PR #3736:
URL: https://github.com/apache/calcite/pull/3736#discussion_r1530716832
##########
core/src/main/java/org/apache/calcite/rel/core/Window.java:
##########
@@ -111,6 +111,14 @@ public Window(RelOptCluster cluster, RelTraitSet traitSet,
RelNode input,
this(cluster, traitSet, Collections.emptyList(), input, constants,
rowType, groups);
}
+ /**
+ * Creates a copy of this {@code Window}.
+ *
+ * @param constants List of constants that are additional inputs
+ * @return New {@code Window}
+ */
+ public abstract Window copy(List<RexLiteral> constants);
Review Comment:
I can rename this, but `copy` is also used like this in other classes.
https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/rel/core/Filter.java#L125
https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/rel/logical/LogicalFilter.java#L148
Should I still rename this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
