mihaibudiu commented on code in PR #238:
URL: https://github.com/apache/calcite-avatica/pull/238#discussion_r1531438930


##########
core/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java:
##########
@@ -739,6 +744,25 @@ private static int parseFraction(String v, int multiplier) 
{
     return r;
   }
 
+  /** Lenient date validation.  This accepts more date strings
+   * than validateDate: it does not insist on having two-digit
+   * values for days and months, and accepts spaces around the value.
+   * @param s     A string representing a date.
+   */
+  private static void validateLenientDate(String s) {

Review Comment:
   I have added a commit to validate month and year values.
   Turns out year 0 is not legal in the Gregorian calendar, so I had to delete 
some tests that were using it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to