rubenada commented on PR #3739: URL: https://github.com/apache/calcite/pull/3739#issuecomment-2014606439
Thanks for the review @snuyanzin . I have made some minor changes, based on some feedback in Jira. > It seems it never returns null, In that case should we remove @Nullable or replace it with @NonNull? I tried both removing @Nullable and replacing it with @NonNull, but in both cases CheckFramework failed (due to the annotations used by the method(s) called by this one). So I think it is not clever enough to grasp the situation (or I'm not clever enough to make it understand it). Since this annotation is not really a part of the fix, I propose to keep the original state in this regard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
