mihaibudiu commented on code in PR #3748:
URL: https://github.com/apache/calcite/pull/3748#discussion_r1548173980
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -7008,18 +7008,20 @@ void checkRegexpExtract(SqlOperatorFixture f0,
FunctionAlias functionAlias) {
"[1, 2, null, 3]", "INTEGER ARRAY NOT NULL");
f1.checkScalar("array_insert(array[2, 3, 4], 1, 1)",
"[1, 2, 3, 4]", "INTEGER NOT NULL ARRAY NOT NULL");
- f1.checkScalar("array_insert(array[1, 3, 4], -2, 2)",
+ f1.checkScalar("array_insert(array[1, 3, 4], -1, 2)",
+ "[1, 3, 4, 2]", "INTEGER NOT NULL ARRAY NOT NULL");
+ f1.checkScalar("array_insert(array[1, 3, 4], -3, 2)",
"[1, 2, 3, 4]", "INTEGER NOT NULL ARRAY NOT NULL");
- f1.checkScalar("array_insert(array[2, 3, null, 4], -5, 1)",
+ f1.checkScalar("array_insert(array[2, 3, null, 4], -6, 1)",
Review Comment:
these two forms are equivalent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
